I had a 5 hour round a Rudding Park once. I'm never going back.
Knaresborough was ok as was Weatherby.
Oakdale for me. The 1st is a quirky par 4, teeing off from an extremely elevated tee. 9th is a brilliant par 3 protected by a pond. The par 4 18th is tighter than the proverbial ducks whatchamacallit with a steam in front of the green and a cliff behind. Scattered among these is a myriad of interesting golf holes.
Fulford is probably handiest and best for York. We hold a few county fixtures there. York Golf Club at Strensall is probably nearly as good but a bit far out and isolated. I would suggest Ganton is too far.
Rudding Park is in Harrogate. But none are really on a convenient route from York to Thirsk.
Nearest to that route is Easingwold. Thirsk and Fulford are at each end. Fulford is the best but nothing to choose between the others (except may be slightly cheaper. They all take the County Card.